Skip to content

docs(storage): add comprehensive JSDoc documentation to GetSignedUrlConfig interface properties - #27

Open
thiyaguk09 wants to merge 7 commits into
mainfrom
docs/issue-7352-getsignedurlconfig
Open

docs(storage): add comprehensive JSDoc documentation to GetSignedUrlConfig interface properties#27
thiyaguk09 wants to merge 7 commits into
mainfrom
docs/issue-7352-getsignedurlconfig

Conversation

@thiyaguk09

Copy link
Copy Markdown
Owner

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes the properties of the GetSignedUrlConfig interface in handwritten/storage/src/file.ts and adds comprehensive JSDoc documentation to each field to improve code readability and developer experience. No review comments were provided, and there is no additional feedback.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread handwritten/storage/src/file.ts
@thiyaguk09
thiyaguk09 requested a review from gurusai-voleti July 2, 2026 12:28
Comment thread handwritten/storage/src/file.ts Outdated
@thiyaguk09
thiyaguk09 force-pushed the docs/issue-7352-getsignedurlconfig branch from 0766585 to 22feffb Compare July 10, 2026 12:29
@thiyaguk09
thiyaguk09 force-pushed the docs/issue-7352-getsignedurlconfig branch 5 times, most recently from b448a54 to ea0d9c0 Compare July 27, 2026 06:48
@thiyaguk09
thiyaguk09 force-pushed the docs/issue-7352-getsignedurlconfig branch 4 times, most recently from 187fe90 to ee10000 Compare July 30, 2026 04:48
westarle and others added 7 commits July 30, 2026 13:28
…pis#9028)

Update pinned action version comments to match exact SemVer tags (e.g.,
# v6.0.3, # v4.3.1, # v6.4.0) to satisfy online zizmor scanner.
…typescript (googleapis#9029)

## Description

Upgrade the gapic-generator-typescript to node version 22. 

## Impact

Ensures users upgrade their runtime to Node 22 and don't encounter
problems due to legacy Node 18 issues.

## Changes

Node was upgraded to version 22 in two package.json files and then `npm
run baseline` was run.

Just the following files were updated:

core/generator/gapic-generator-typescript/templates/cjs/typescript_gapic/package.json

core/generator/gapic-generator-typescript/templates/esm/typescript_gapic/package.json

Then in core/generator/gapic-generator-typescript we ran the following
command:
`npm run baseline`


## Next steps

Next we are going to upgrade all the packages in the root `packages`
directory to separate concerns about the packages and the
gapic-typescript-generator.
docs: update virtualHostedStyle JSDoc description
@thiyaguk09
thiyaguk09 force-pushed the docs/issue-7352-getsignedurlconfig branch from ee10000 to a9f2e29 Compare July 31, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants